Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation Test Bench POST #1

Closed
saumier opened this issue Apr 11, 2024 · 5 comments · Fixed by #2
Closed

Reconciliation Test Bench POST #1

saumier opened this issue Apr 11, 2024 · 5 comments · Fixed by #2
Assignees

Comments

@saumier
Copy link
Member

saumier commented Apr 11, 2024

@dev-aravind Commented that the Reconciliation API spec only accepts POST requests but the test bench is currently using GET. I proposed to the Reconciliation CG that we update the Test bench and they agreed.

Reconciliation CG April 2024 meeting notes:

@saumier
Copy link
Member Author

saumier commented Apr 11, 2024

@AbhishekPAnil I think this would be a good task for you. The test bench is in React. I think this could be a good contribution from Culture Creates to this W3C open group. You would also see how the project is setup in Github (they also use Netlify to preview PRs) and how they call the Reconciliation API and run unit tests.

This should be done by first week of May 2024.

@sahalali @AbhishekPAnil Let me know if you can take this on in your current work load. I suggest you take a couple hours to look at the react test bench and see if you can get it running locally on your machine. Then I can explain the changes needed.

@saumier saumier changed the title Reconciliation Testbench Reconciliation Testbench POST Apr 12, 2024
@saumier saumier changed the title Reconciliation Testbench POST Reconciliation Test Bench POST Apr 12, 2024
@saumier
Copy link
Member Author

saumier commented Apr 22, 2024

@AbhishekPAnil When making changes to the test bench, please refer to the lastest published spec which is https://www.w3.org/community/reports/reconciliation/CG-FINAL-specs-0.2-20230410/

The group is working on a new version of the spec which has breaking changes, so until the draft is officially published the official W3C test bench should follow version 0.2 listed above.

@saumier saumier transferred this issue from culturecreates/artsdata-reconciliation Apr 23, 2024
@saumier
Copy link
Member Author

saumier commented Apr 23, 2024

@AbhishekPAnil I propose you make your changes in this forked repo. It is synched with the original testbench. It also deploys on one of our Github pages for testing https://culturecreates.github.io/testbench/. Then we can submit the contribution. First we can test on the branch that gets deployed to culture creates Github pages. The trigger for the Github action to publish the website is when master is pushed to gh-pages branch.

@saumier
Copy link
Member Author

saumier commented Apr 24, 2024

@AbhishekPAnil Your code changes look good, but I am having trouble running the tests (the existing ones) and I am not sure which version of node I should be using. Which version of node did you use and did the existing tests pass?

@saumier saumier assigned AbhishekPAnil and unassigned saumier Apr 24, 2024
@AbhishekPAnil
Copy link

AbhishekPAnil commented Apr 25, 2024

@AbhishekPAnil Your code changes look good, but I am having trouble running the tests (the existing ones) and I am not sure which version of node I should be using. Which version of node did you use and did the existing tests pass?

Can you try it with node 15,thats the onementioned in the workflows.For me it worked with 14 as well.

I didn't try out the tests as I didn't see any existing tests written other than the default App.test.

AbhishekPAnil added a commit that referenced this issue Jul 5, 2024
* Changed the reconciliation service request method to post,added the respective payload.closes #1

* Node engine version added to package json

* set node to v20 for engines and test matrix

* bumped to v0.2.0

---------

Co-authored-by: Abhishek P Anil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants