Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WHEEL_LINUX_CONFIGS structure in dist_config.py #166

Open
kmaehashi opened this issue Aug 5, 2021 · 0 comments
Open

Improve WHEEL_LINUX_CONFIGS structure in dist_config.py #166

kmaehashi opened this issue Aug 5, 2021 · 0 comments

Comments

@kmaehashi
Copy link
Member

kmaehashi commented Aug 5, 2021

Currently, wheel config is defined like this:

    '10.0': {
        'name': 'cupy-cuda100',
        'kind': 'cuda',
        'image': 'nvidia/cuda:10.0-devel-centos6',
        'libs': [
        ],
        'includes': [
        ],
        'preloads': ['nccl', 'cudnn'],
        'verify_image': 'nvidia/cuda:10.0-devel-{system}',
        'verify_systems': ['ubuntu16.04'],
        'system_packages': '',
    },

I'd like to change to this:

    'cuda-10.0': {
        'name': 'cupy-cuda100',
        'platform': 'cuda',
        'platform_version': '10.0',
        'preloads': ['nccl', 'cudnn'],
        'builder': {
            'image': 'nvidia/cuda:10.0-devel-centos6',
            'template': 'cuda',  # template Dockerfile
            'envs': {'CUPY_USE_CUDA_PYTHON': '0'},
            'libs': [],
        },
        'verifier': {
            'images': [
                {'image': 'nvidia/cuda:10.0-devel-ubuntu16.04', 'template': 'cuda'}
            ]
        },
    },
  • Add cuda-* prefix to configuration names
  • Merge WHEEL_LINUX_CONFIGS and SDIST_CONFIG
  • Allow specifying Dockerfile template for builder/verifier so that we can use different Dockerfile for builder/verifier (currently Dockerfiles are very hacky to handle CUDA/ROCm, CentOS 6/7 in one Dockerfile)
  • Allow specifying environment variables for each build configuration (e.g., can be used to support CUDA Python, HIP platform list, etc.)
  • Rename kind to platform
  • Remove includes which is no longer used (originally used for ChainerX)
@kmaehashi kmaehashi changed the title Fix WHEEL_LINUX_CONFIGS in dist_config.py Fix WHEEL_LINUX_CONFIGS in dist_config.py Aug 5, 2021
@kmaehashi kmaehashi changed the title Fix WHEEL_LINUX_CONFIGS in dist_config.py Improve WHEEL_LINUX_CONFIGS structure in dist_config.py Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant