You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using your UMAP library in a project and have encountered a limitation that I believe could be addressed with an enhancement to the library.
In my project, I need to access data beyond the vectors themselves during the distance calculation. However, the current implementation of the DistanceCalculation delegate public delegate float DistanceCalculation(float[] x, float[] y) does not support generics, which restricts access to additional data regarding a set of vectors.
One potential solution could be to modify the DistanceCalculation function to support generics. This would allow for extended data access during the distance calculation, increasing the flexibility and applicability of the library for projects like mine that require access to additional data in order to calculate distance.
I understand that this is a non-trivial change and may not align with the current design of the library. However, I believe this enhancement could significantly improve the library's versatility.
I couldn't find another C# implementation of UMAP, and your library has been very useful in my project so far. I'm considering forking the library to implement this change myself, but I wanted to bring this to your attention first in case this is an enhancement you'd be interested in incorporating.
Thank you for your time and consideration.
The text was updated successfully, but these errors were encountered:
Hi @Arlodotexe, that's a great suggestion, but I'm afraid it might be a bit complicated to implement due to how the calculation works. If you want to give it a try on a PR, happy to merge it if it works!
I'm using your UMAP library in a project and have encountered a limitation that I believe could be addressed with an enhancement to the library.
In my project, I need to access data beyond the vectors themselves during the distance calculation. However, the current implementation of the DistanceCalculation delegate
public delegate float DistanceCalculation(float[] x, float[] y)
does not support generics, which restricts access to additional data regarding a set of vectors.One potential solution could be to modify the DistanceCalculation function to support generics. This would allow for extended data access during the distance calculation, increasing the flexibility and applicability of the library for projects like mine that require access to additional data in order to calculate distance.
I understand that this is a non-trivial change and may not align with the current design of the library. However, I believe this enhancement could significantly improve the library's versatility.
I couldn't find another C# implementation of UMAP, and your library has been very useful in my project so far. I'm considering forking the library to implement this change myself, but I wanted to bring this to your attention first in case this is an enhancement you'd be interested in incorporating.
Thank you for your time and consideration.
The text was updated successfully, but these errors were encountered: