Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS only configured if secretName is set #81

Open
dozer75 opened this issue Feb 2, 2024 · 0 comments
Open

TLS only configured if secretName is set #81

dozer75 opened this issue Feb 2, 2024 · 0 comments

Comments

@dozer75
Copy link

dozer75 commented Feb 2, 2024

The TLS section of the ingress is not configured unless a secretName is provided, however this is not always necessary. An NGINX ingress controller can have a default certificate configured using the default-ssl-certificate. In these cases the NGINX will always use the certificate configured here for TLS where this is not configured in the ingress.

The issue is here. The conditional setting should not use secretName only as a condition for enabling TLS in the ingress. It should also enable e.g. if tlsHost are set or maybe a new enableTLS flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant