-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse selection (& scroll) is extremely sluggish and I don't know why #179
Comments
Try adjusting scroll amount in your configuration file ( I like to use terminal.scroll_amount = 4 in mine This will shift up/down by 4 lines at a time. I should probably update the default (currently 2) to a higher amount because you're right, I find it too sluggish too. |
Still sluggish for the mouse selection function. About the scroll: yea, that will hide a bit the slugginess, still not so smooth, I need to say.
|
I have noticed that when selecting downwards past the viewport (i.e. moving the cursor down to the bottom of the editor to try to select text that is out of view) is a bit sluggish. Is this what you are referring to? Or are you referring to the skipping of multiple lines at once as not smooth enough? Perhaps both? |
So I've performed a thorough investigation into Ox's performance and found the rendering process to be really slow - I just tried a simple optimisation and found the editor renders in the terminal ~3x faster than before, so I really hope this helps make it feel less sluggish. (It's due to be released in 0.6.10) I'm also going to set the default scroll amount to |
Bottom-up, top-down, inside or outside the viewport: doesn't makes any differences.
Not clear to me what you are referring to.
I'm referring to select region of text with the use of the mouse. I could make a screen recording of it if you can point me some light weight tool for windows (or linux/wayland) ( I'm using ox over ssh over Windows Terminal, but it is sluggish also on the terminal emulator on the real machine )
NICE, looking forward to try it Thinking of it I might use OBS, I'll post a small video if I will able to do it |
0.6.10 released (this might make scrolling smoother?) |
I'm sorry, man. It is basically the same as before. Look at the CPU usage while selecting, using a full core. I've tried both remotely (LAN) and locally, same behaviour except for one thing: while using ox remotely (windows terminal) the text changes color but I think it is a problem of mine and not ox's. I'm not a good programmer and I cannot think of myself writing a text editor but I feel like there is something intrinsically wrong in this implementation of text selection. As I said before: other text editors (vim, nano, micro) do not have such a weird problem. Am I the only one to have this problem? ox.mp4 |
Thanks for sharing this. May I ask which terminal emulator you are using and how you installed Ox? |
Installed on Archlinux via AUR (paru), the package is ox-bin. |
I greatly optimised the front-end with 0.6.10, so maybe the continued performance issues is because of inefficiencies in the back-end. I've already found some inefficiencies that I'm working on patching 👍 |
I've done some optimisations in 0.7.1 - not sure how much impact they will have - but I've tried targeting a few areas of blatant inefficiency so hopefully there should be at least some improvement. |
Cool! Indeed, the optimizations worked. |
That's great news! I'll keep looking at ways to optimise and hopefully, we can get Ox over SSH running more efficiently. |
What is the bug?
Mouse selection (& scroll) is extremely sluggish
What did you do to get the bug?
I was selecting some text from 170 lines docker compose file where half of it is made of commented lines.
ox 0.6.9 on Archilinux
What behaviour were you expecting?
At least good as in other text editor (micro)
The text was updated successfully, but these errors were encountered: