Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change health to either always use the parameter full=True or always use full=False #180

Open
saint-rat opened this issue May 22, 2024 · 0 comments

Comments

@saint-rat
Copy link
Contributor

On the main lend/crvUSD UI when it calculates health it seems to call the health view method with full=True when the health is green (oracle price is >3 bands higher), and full=False when health is yellow (oracle price is <=3 bands higher). Is this the desired behavior? Just seems confusing for the user that their health evaporates for seemingly no reason.

Eg. for wstETH market with active band -65 and oracle price 4,391.15
1 wstETH collateral, 3660 debt: 7.71% health (green) - bands -61 to -52
1 wstETH collateral, 3670 debt: 7.42% health (green) - bands -61 to -52
1 wstETH collateral, 3680 debt: 4.23% health (yellow) - bands -62 to -53 (by my calcs I think it should be around ~7% with full=True)

I personally think it would be clearer to always call with full=True or full=False (with full=True as my preference). Changing the full parameter without telling the user why seems a bit misleading to me.

What's everyone else think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant