Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored tests #55

Merged
merged 49 commits into from
Nov 27, 2024
Merged

Refactored tests #55

merged 49 commits into from
Nov 27, 2024

Conversation

heswithme
Copy link
Contributor

@heswithme heswithme commented Sep 27, 2024

Main Goal: Make all tests pass.
Ways to achieve: Go through each failing test and figure out failure reason, attempt to fix
Files changed: Almost every test_*.py was altered in one way or another, some more, some less.

List of changes:

  • Optimized and improved test fixtures
  • Reworked test generation to cover more cases and handle rebasing tokens
  • Fixed inconsistent fixtures affecting Meta and StableSwap pools
  • Refactored many tests to ensure compatibility with rebasing tokens
  • Applied xskip to edge cases in extreme unbalanced situations where tests designed for normal cases may fail.

This PR ensures the existing test suite passes, while not explicitly introducing new test functions/scenarios.

Comparison
One of initial test run reports vs. Latest test run report
Significant increase in test amounts is related to enabling extensive token pair search (i.e. plain+rebasing != rebasing+plain).

Expected improvement:
image

@heswithme heswithme self-assigned this Sep 30, 2024
@bout3fiddy bout3fiddy merged commit fd54b9a into curvefi:main Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants