From 42e9efcc3b4fddc4c031917b4f2a21d0ab1a0119 Mon Sep 17 00:00:00 2001
From: Shahroz Khan <shrozali@gmail.com>
Date: Wed, 18 Dec 2024 15:58:41 +0500
Subject: [PATCH] attempt 2

---
 .github/workflows/build-sample-apps.yml | 3 +--
 Apps/fastlane/helpers/version_helper.rb | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build-sample-apps.yml b/.github/workflows/build-sample-apps.yml
index b45a0093..4f349a5e 100644
--- a/.github/workflows/build-sample-apps.yml
+++ b/.github/workflows/build-sample-apps.yml
@@ -3,7 +3,6 @@ name: Build sample apps
 on:
   pull_request: # build sample apps for every commit pushed to an open pull request (including drafts)
   push:
-    branches: [ test-push-flag ]
 
 concurrency: # cancel previous workflow run if one exists.
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -175,7 +174,7 @@ jobs:
         env:
           FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64: ${{ secrets.FIREBASE_APP_DISTRIBUTION_SERVICE_ACCOUNT_CREDS_B64 }}
         continue-on-error: true # continue to build iOS app even if Android build fails
-        
+
       # Update PR comment with build information
 
       - name: Update sample builds PR comment with build information
diff --git a/Apps/fastlane/helpers/version_helper.rb b/Apps/fastlane/helpers/version_helper.rb
index 0a3586c1..b9031782 100644
--- a/Apps/fastlane/helpers/version_helper.rb
+++ b/Apps/fastlane/helpers/version_helper.rb
@@ -42,9 +42,9 @@
   app_version_code = (current_time.to_f / 60).to_i
 
   UI.message("Generated new versions => SDK: #{sdk_version_name}, App: #{app_version_name} (#{app_version_code})")
-  sh("echo SDK_VERSION_NAME=#{"5.4.0"} >> $GITHUB_ENV")
-  sh("echo APP_VERSION_NAME=#{"5.4.0"} >> $GITHUB_ENV")
-  sh("echo APP_VERSION_CODE=#{"5.4.0"} >> $GITHUB_ENV")
+  sh("echo SDK_VERSION_NAME=#{sdk_version_name} >> $GITHUB_ENV")
+  sh("echo APP_VERSION_NAME=#{app_version_name} >> $GITHUB_ENV")
+  sh("echo APP_VERSION_CODE=#{app_version_code} >> $GITHUB_ENV")
 end
 
 # Helper method to update Android version