New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: in-app messaging fixes and improvements #342

Merged

mrehan27 merged 5 commits into feature/cdp-main from rehan/mbl-538-in-app-ios

Oct 7, 2024

Merged

chore: in-app messaging fixes and improvements #342

lock file updates

GitHub Actions / eslint results succeeded Oct 7, 2024 in 1s

eslint results

0 ESLint error(s) and 51 ESLint warning(s) found

Details

51 Warning(s):

`Apps/APN/App.js` line `107`

Start Line: 107
End Line: 107
Message: Inline style: { flex: 1 }
- From: [react-native/no-inline-styles]

`Apps/APN/src/screens/InternalSettings.js` line `2`

Start Line: 2
End Line: 2
Message: 'Text' is defined but never used.
- From: [no-unused-vars]

`Apps/APN/src/screens/Settings.js` line `15`

Start Line: 15
End Line: 15
Message: 'StyleSheet' is defined but never used.
- From: [no-unused-vars]

`lib/commonjs/cio-config.js` line `10`

Start Line: 10
End Line: 10
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/cio-config.js` line `11`

Start Line: 11
End Line: 11
Message: 'CioRegion' is assigned a value but never used.
- From: [no-unused-vars]

`lib/commonjs/cio-config.js` line `11`

Start Line: 11
End Line: 11
Message: 'CioRegion' is already declared in the upper scope on line 11 column 5.
- From: [no-shadow]

`lib/commonjs/cio-config.js` line `16`

Start Line: 16
End Line: 16
Message: 'CioLogLevel' is assigned a value but never used.
- From: [no-unused-vars]

`lib/commonjs/cio-config.js` line `16`

Start Line: 16
End Line: 16
Message: 'CioLogLevel' is already declared in the upper scope on line 16 column 5.
- From: [no-shadow]

`lib/commonjs/cio-config.js` line `23`

Start Line: 23
End Line: 23
Message: 'PushClickBehaviorAndroid' is assigned a value but never used.
- From: [no-unused-vars]

`lib/commonjs/cio-config.js` line `24`

Start Line: 24
End Line: 24
Message: 'PushClickBehaviorAndroid' is already declared in the upper scope on line 23 column 5.
- From: [no-shadow]

`lib/commonjs/cio-config.js` line `31`

Start Line: 31
End Line: 31
Message: 'CioPushPermissionStatus' is assigned a value but never used.
- From: [no-unused-vars]

`lib/commonjs/cio-config.js` line `32`

Start Line: 32
End Line: 32
Message: 'CioPushPermissionStatus' is already declared in the upper scope on line 31 column 5.
- From: [no-shadow]

`lib/commonjs/customerio-cdp.js` line `6`

Start Line: 6
End Line: 6
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-cdp.js` line `33`

Start Line: 33
End Line: 33
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-cdp.js` line `69`

Start Line: 69
End Line: 69
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-cdp.js` line `70`

Start Line: 70
End Line: 70
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `9`

Start Line: 9
End Line: 9
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `31`

Start Line: 31
End Line: 31
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `105`

Start Line: 105
End Line: 105
Message: 'InAppMessageEventType' is already declared in the upper scope on line 104 column 5.
- From: [no-shadow]

`lib/commonjs/customerio-inapp.js` line `117`

Start Line: 117
End Line: 117
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `118`

Start Line: 118
End Line: 118
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `119`

Start Line: 119
End Line: 119
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `120`

Start Line: 120
End Line: 120
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-inapp.js` line `121`

Start Line: 121
End Line: 121
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-push.js` line `6`

Start Line: 6
End Line: 6
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/customerio-push.js` line `120`

Start Line: 120
End Line: 120
Message: Expected '===' and instead saw '=='.
- From: [eqeqeq]

`lib/commonjs/native-logger-listener.js` line `6`

Start Line: 6
End Line: 6
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/types/PushClickBehaviorAndroid.js` line `6`

Start Line: 6
End Line: 6
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/types/PushClickBehaviorAndroid.js` line `7`

Start Line: 7
End Line: 7
Message: 'PushClickBehaviorAndroid' is assigned a value but never used.
- From: [no-unused-vars]

`lib/commonjs/types/PushClickBehaviorAndroid.js` line `8`

Start Line: 8
End Line: 8
Message: 'PushClickBehaviorAndroid' is already declared in the upper scope on line 7 column 5.
- From: [no-shadow]

`lib/commonjs/types/PushPermissionStatus.js` line `6`

Start Line: 6
End Line: 6
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/commonjs/types/PushPermissionStatus.js` line `7`

Start Line: 7
End Line: 7
Message: 'PushPermissionStatus' is assigned a value but never used.
- From: [no-unused-vars]

`lib/commonjs/types/PushPermissionStatus.js` line `8`

Start Line: 8
End Line: 8
Message: 'PushPermissionStatus' is already declared in the upper scope on line 7 column 5.
- From: [no-shadow]

`lib/module/cio-config.js` line `1`

Start Line: 1
End Line: 1
Message: 'CioRegion' is already declared in the upper scope on line 1 column 12.
- From: [no-shadow]

`lib/module/cio-config.js` line `6`

Start Line: 6
End Line: 6
Message: 'CioLogLevel' is already declared in the upper scope on line 6 column 12.
- From: [no-shadow]

`lib/module/cio-config.js` line `14`

Start Line: 14
End Line: 14
Message: 'PushClickBehaviorAndroid' is already declared in the upper scope on line 13 column 12.
- From: [no-shadow]

`lib/module/cio-config.js` line `22`

Start Line: 22
End Line: 22
Message: 'CioPushPermissionStatus' is already declared in the upper scope on line 21 column 12.
- From: [no-shadow]

`lib/module/customerio-cdp.js` line `22`

Start Line: 22
End Line: 22
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-cdp.js` line `62`

Start Line: 62
End Line: 62
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-cdp.js` line `63`

Start Line: 63
End Line: 63
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-inapp.js` line `21`

Start Line: 21
End Line: 21
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-inapp.js` line `94`

Start Line: 94
End Line: 94
Message: 'InAppMessageEventType' is already declared in the upper scope on line 94 column 5.
- From: [no-shadow]

`lib/module/customerio-inapp.js` line `106`

Start Line: 106
End Line: 106
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-inapp.js` line `107`

Start Line: 107
End Line: 107
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-inapp.js` line `108`

Start Line: 108
End Line: 108
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-inapp.js` line `109`

Start Line: 109
End Line: 109
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-inapp.js` line `110`

Start Line: 110
End Line: 110
Message: Expected 'undefined' and instead saw 'void'.
- From: [no-void]

`lib/module/customerio-push.js` line `114`

Start Line: 114
End Line: 114
Message: Expected '===' and instead saw '=='.
- From: [eqeqeq]

`lib/module/types/PushClickBehaviorAndroid.js` line `2`

Start Line: 2
End Line: 2
Message: 'PushClickBehaviorAndroid' is already declared in the upper scope on line 1 column 12.
- From: [no-shadow]

`lib/module/types/PushPermissionStatus.js` line `2`

Start Line: 2
End Line: 2
Message: 'PushPermissionStatus' is already declared in the upper scope on line 1 column 12.
- From: [no-shadow]

`src/customerio-push.ts` line `118`

Start Line: 118
End Line: 118
Message: Expected '===' and instead saw '=='.
- From: [eqeqeq]

Annotations

Check warning on line 118 in src/customerio-push.ts

github-actions / eslint results

src/customerio-push.ts#L118

[eqeqeq] Expected '===' and instead saw '=='.

Check warning on line 107 in Apps/APN/App.js

github-actions / eslint results

Apps/APN/App.js#L107

[react-native/no-inline-styles] Inline style: { flex: 1 }

Check warning on line 2 in Apps/APN/src/screens/InternalSettings.js

github-actions / eslint results

Apps/APN/src/screens/InternalSettings.js#L2

[no-unused-vars] 'Text' is defined but never used.

Check warning on line 15 in Apps/APN/src/screens/Settings.js

github-actions / eslint results

Apps/APN/src/screens/Settings.js#L15

[no-unused-vars] 'StyleSheet' is defined but never used.

Check warning on line 10 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L10

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 11 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L11

[no-unused-vars] 'CioRegion' is assigned a value but never used.

Check warning on line 11 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L11

[no-shadow] 'CioRegion' is already declared in the upper scope on line 11 column 5.

Check warning on line 16 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L16

[no-unused-vars] 'CioLogLevel' is assigned a value but never used.

Check warning on line 16 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L16

[no-shadow] 'CioLogLevel' is already declared in the upper scope on line 16 column 5.

Check warning on line 23 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L23

[no-unused-vars] 'PushClickBehaviorAndroid' is assigned a value but never used.

Check warning on line 24 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L24

[no-shadow] 'PushClickBehaviorAndroid' is already declared in the upper scope on line 23 column 5.

Check warning on line 31 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L31

[no-unused-vars] 'CioPushPermissionStatus' is assigned a value but never used.

Check warning on line 32 in lib/commonjs/cio-config.js

github-actions / eslint results

lib/commonjs/cio-config.js#L32

[no-shadow] 'CioPushPermissionStatus' is already declared in the upper scope on line 31 column 5.

Check warning on line 6 in lib/commonjs/customerio-cdp.js

github-actions / eslint results

lib/commonjs/customerio-cdp.js#L6

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 33 in lib/commonjs/customerio-cdp.js

github-actions / eslint results

lib/commonjs/customerio-cdp.js#L33

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 69 in lib/commonjs/customerio-cdp.js

github-actions / eslint results

lib/commonjs/customerio-cdp.js#L69

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 70 in lib/commonjs/customerio-cdp.js

github-actions / eslint results

lib/commonjs/customerio-cdp.js#L70

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 9 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L9

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 31 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L31

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 105 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L105

[no-shadow] 'InAppMessageEventType' is already declared in the upper scope on line 104 column 5.

Check warning on line 117 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L117

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 118 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L118

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 119 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L119

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 120 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L120

[no-void] Expected 'undefined' and instead saw 'void'.

Check warning on line 121 in lib/commonjs/customerio-inapp.js

github-actions / eslint results

lib/commonjs/customerio-inapp.js#L121

[no-void] Expected 'undefined' and instead saw 'void'.

View more details on GitHub Actions