-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn the user when patches.lock is not up to date #479
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
In patchPackage if we check hash for the current patches.lock.json file and if there is any change then execute command to relock the patches.lock.json, then I guess this problem will be fixed. |
No, relock should always be an explicit operation. We should never automatically do this. |
You can call isFresh() on the Locker class to check this. If there's a hash mismatch, emit a warning to the console. Def shouldn't relock automatically though. |
Verification
composer self-update
)composer update cweagans/composer-patches
)What were you trying to do (and why)?
#472 (comment)
Trying to change a patch/setting.
What happened? What did you expect to happen?
The plugin did nothing and ignored all changes. It should have warned when the resolved patches/settings were different from the ones that generated the lock file.
Contents of
composer.json
Contents of
patches.lock
Full output of
composer patches-doctor
Full output of relevant Composer command with the
-vvv
flag addedThe text was updated successfully, but these errors were encountered: