From 5bdf66074bd15d5bdbc24cb6ebb377ed0dd56af1 Mon Sep 17 00:00:00 2001
From: Jack Jansen <Jack.Jansen@cwi.nl>
Date: Thu, 26 Dec 2024 13:17:34 +0100
Subject: [PATCH] Be a bit smarter about when to turn on/off.

---
 src/iotsaInput.cpp | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/iotsaInput.cpp b/src/iotsaInput.cpp
index d7682b4..ad748b9 100644
--- a/src/iotsaInput.cpp
+++ b/src/iotsaInput.cpp
@@ -460,16 +460,26 @@ void CyclingButton::loop() {
 }
 
 bool CyclingButton::_pressedCallback() {
+  IotsaSerial.printf("CyclingButton callback for pressed %d repeat %d, state=%d\n", button.pressed, button.repeatCount, state);
   if (button.pressed) {
-    // The button was pressed. We ignore the first press.
+    // We ignore the first press. We take action on repeat (turn on and increase level)
+    // or release (toggle on/off).
     if (button.repeatCount == 0) return true;
+    // The button was pressed. We turn on the light if it was off.
+    if (!state) {
+      state = true;
+      if (stateVar) *stateVar = state;
+      if (stateCallback) stateCallback();
+    }
     if (_changeValue(direction)) {
+      IotsaSerial.printf("CyclingButton reached limit, now dir=%d", direction);
       direction = -direction;
     }
   } else {
     // The button was released. If this was a short press we toggle on/off.
     if (button.repeatCount == 0) {
       state = !state;
+      IotsaSerial.printf("CyclingButton state=%d\n", state);
       if (stateVar) *stateVar = state;
       if (stateCallback) stateCallback();
     }