Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONTIME, LIVETIME, EXPOSURE, DTCOR in merged products #618

Open
3 tasks
kglotfelty opened this issue May 5, 2022 · 4 comments
Open
3 tasks

ONTIME, LIVETIME, EXPOSURE, DTCOR in merged products #618

kglotfelty opened this issue May 5, 2022 · 4 comments
Labels
Discussion Topics for Discussion

Comments

@kglotfelty
Copy link
Member

Outputs from merge_obs and combine_spectra are doing {stuff} to provide meaningful values for some subset of the ONTIME, EXPOSURE, and LIVETIME keywords.

This issue is to discuss which keywords are and should be being updated and how. For example

  • Should we be writing ONTIME as SUM(ONTIME_n)
  • Should we be writing DTCOR as the ONTIME weighted sum of the individual DTCOR_n values
  • Should we go ahead and delete per-chip values? Do they still have any meaning in the merged products?

Some may be tool specific (eg combine_spectra with method=avg|sum may have different behavior).

@kglotfelty kglotfelty added the Discussion Topics for Discussion label May 5, 2022
@DougBurke
Copy link
Member

DougBurke commented May 5, 2022

I think I have been using the @ gti trick to ensure we filter things like the asol file to match the data (memory is fuzzy and vague) and I know that appears to be problematic (I didn't follow the details so it hopefully isn't an issue for what we are doing). if we are doing it.

@kglotfelty
Copy link
Member Author

kglotfelty commented May 5, 2022

The @ gti thing is only a problem if you filter and bin in the same command.

So if a user supplies fluximage an infile with "evt[@ gti]" then they might not be getting the correct image. But if just using to filter a table then it looked to be OK.

@kglotfelty
Copy link
Member Author

The @ gti (no space) was tagging someone

@kglotfelty
Copy link
Member Author

Note: this looks to be a duplicate of #177 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Topics for Discussion
Projects
None yet
Development

No branches or pull requests

2 participants