Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install version? #774

Open
kglotfelty opened this issue Jun 29, 2023 · 0 comments
Open

pip install version? #774

kglotfelty opened this issue Jun 29, 2023 · 0 comments
Labels
Discussion Topics for Discussion

Comments

@kglotfelty
Copy link
Member

This may become a bigger topic.

Right now to test the contrib package the "best" way is to create & activate a test conda environment and do a pip install .

This works, but right now when I do that I am getting:

% conda list | grep contrib
ciao-contrib              4.15.0                   pypi_0    pypi

4.15.0 even though I've rebased my branch to 4.15.2

% head -3 Changes.CIAO_scripts 
## 4.15.2 - June 2023

New scripts

I'm assuming that this is coming from setup.py -- I don't see where else the version number is specified.

So, should we also be updating setup.py with each contrib release to match the version number? It's not a big things since it's just us testing, but might make things cleaner.


Then the bigger question (and probably a separate Issue) ...

Should we change our interface w/ DS. Since ciao-install is dead and the contrib subdir is no-more, should we still be creating the same tar file?

I'm thinking we could tag the release and then their conda recipe could just pull the updated version and use pip to install it, instead of doing whatever it does right now to reorg the files out of the contrib subdir. We could then do things like define a CIAOX tag to get things into the CIAOX builds without having to cut them a new tar file.

@kglotfelty kglotfelty added the Discussion Topics for Discussion label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Topics for Discussion
Projects
None yet
Development

No branches or pull requests

1 participant