Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specextract: should it set tabstops when calling dmgroup? #796

Open
DougBurke opened this issue Sep 14, 2023 · 2 comments
Open

specextract: should it set tabstops when calling dmgroup? #796

DougBurke opened this issue Sep 14, 2023 · 2 comments

Comments

@DougBurke
Copy link
Member

In 4.16 I'm hoping that in Sherpa commands like group_counts will automatically ignore the filtered-out data.

Should we allow users to give an energy / wavelength filter and then use that to set up the tabStops. It's a bit annoying to do (need to parse the RMF since we can't guarantee the channel mapping) but it should not be too hard to do. The main difficulty comes in designing a useful and usable API. But hey, what's 2 or more parameters, am I right?

@nplee
Copy link
Contributor

nplee commented Sep 14, 2023

think it's a pairing of tabspec/tabcolumn and/or stopspec/stopcolumn in dmgroup, haven't looked too deeply into it... and technically, we already have an energy parameter available to define the grid that the responses are generated on...

@kglotfelty
Copy link
Member

The energy grid the responses are created on isn't necessary the range you want to fit. you want a wider energy range in the responses than you fit so that when you convolve with the RMF the channel edges of the noticed energy range get the contribution from the out-of-noticed-range energies.

I'm also thinking that you don't always just fit one range. I imagine that folks need to fit certain model components to different energy ranges, freeze those values, and then change the energy range to fit a different feature. [I'm thinking cases where say you want to fit the Fe55 line first to freeze it's location and then fit the rest of the spectrum; or fit the low energy first to freeze the absorption.]

Of course if sherpa does it (tabsop mapping/matching) then no worries ... but then why group at all in specextract? Answer: XSPEC. So then is there any benefit for xspec users? Or will this introduce another subtle diff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants