Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snap build #6402

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Fix snap build #6402

merged 4 commits into from
Oct 4, 2023

Conversation

BenjaminDeleze
Copy link

Do not install wrenJS dependencies when building the snap are they are not needed.

@BenjaminDeleze BenjaminDeleze added the bug Something isn't working label Oct 4, 2023
@BenjaminDeleze BenjaminDeleze added this to the R2023b-rev1 milestone Oct 4, 2023
@BenjaminDeleze BenjaminDeleze self-assigned this Oct 4, 2023
@BenjaminDeleze BenjaminDeleze added the test sources Start the sources test on all platforms label Oct 4, 2023
@BenjaminDeleze BenjaminDeleze marked this pull request as ready for review October 4, 2023 07:18
@BenjaminDeleze BenjaminDeleze requested a review from a team as a code owner October 4, 2023 07:18
omichel
omichel approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BenjaminDeleze BenjaminDeleze merged commit 43ece50 into master Oct 4, 2023
41 of 42 checks passed
@BenjaminDeleze BenjaminDeleze deleted the fix-snap branch October 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@BenjaminDeleze BenjaminDeleze

Labels
bug Something isn't working test sources Start the sources test on all platforms
Milestone
R2023b-rev1
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminDeleze @omichel