Fix omni directional cylindrical test failing #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camera, which are only partially visible are recognized
omichel
requested changes
Oct 5, 2023
|
I added a new test which checks for a perpendicular object in the camera frame regarding #6395 . I also did some reformatting regarding clang issues. |
|
It seems that there are more clang format issues. |
|
I did another update to the clang formatting. This time it seems all test were running successful. |
|
Thank you. Is the PR ready for review? (It is still marked as Draft.) |
|
Yes, I updated it now. |
omichel
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a failing test due to #6396
I changed the mIsOmniDirectional variable back to being horizontalFOV > M_PI and instead reprojected all back points to fix the issue from #6395
I additionally added another object to the recognition test which is perpendicular to the sensor plane to ensure that these objects are also correctly recognized.
I want to add another test which checks that the recognized position is correct as this was a problem in #6395
Related Issues
This pull-request addresses issue #6395
Screenshots
Newly added object for test
Fixed detection
