Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeNode not removed from DOM after thought is deleted #2751

Open
raineorshine opened this issue Dec 31, 2024 · 0 comments
Open

TreeNode not removed from DOM after thought is deleted #2751

raineorshine opened this issue Dec 31, 2024 · 0 comments
Labels
bug Something isn't working preassigned I have someone in mind

Comments

@raineorshine
Copy link
Contributor

As reported in #2596 (review).

We have unmountOnExit so I'm not sure why it's still in the DOM.

Steps to Reproduce

- a
- b
- c

Delete the thought c.

Current Behavior

The TreeNode instance (tree-node) is not removed from the DOM after a thought is deleted.

Screenshot 2024-12-27 at 6 54 53 PM

Expected Behavior

TreeNode elements should be removed from the DOM after a thought is deleted and the deletion animation completes.
@raineorshine raineorshine added the bug Something isn't working label Dec 31, 2024
@raineorshine raineorshine mentioned this issue Dec 31, 2024
Merged
@raineorshine raineorshine added the preassigned I have someone in mind label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working preassigned I have someone in mind
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raineorshine