Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fastClick with role='button' #2776

Open
raineorshine opened this issue Jan 16, 2025 · 0 comments
Open

Replace fastClick with role='button' #2776

raineorshine opened this issue Jan 16, 2025 · 0 comments
Labels
preassigned I have someone in mind refactor Refactor without changing behavior

Comments

@raineorshine
Copy link
Contributor

Based on the discovery in #2752 (comment), it looks like role='button' completely removes the artificial delay added to the mobile onClick event as a hover fallback. Thus we should be able to remove fastClick completely.

Test click, touch, drag-and-drop thoroughly to see if this is a safe change.
@raineorshine raineorshine added the refactor Refactor without changing behavior label Jan 16, 2025
@raineorshine raineorshine added the preassigned I have someone in mind label Jan 19, 2025
raineorshine added a commit that referenced this issue Feb 5, 2025
@raineorshine
Editable: Replace fastClick with click + role=button. Fixes #2804.
ce4f030 
Partial fix of #2776.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
preassigned I have someone in mind refactor Refactor without changing behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raineorshine