Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOM when using gradients_memory's list of checkpointed tensors #18

Open
IdoZach opened this issue Mar 5, 2018 · 1 comment
Open

OOM when using gradients_memory's list of checkpointed tensors #18

IdoZach opened this issue Mar 5, 2018 · 1 comment

Comments

@IdoZach
Copy link

IdoZach commented Mar 5, 2018

First, thanks very much for this contribution!

  • I run my code using the gradients_memory() method, which indeed works.
  • I then try to get the bottleneck tensors it found, by taking the "Checkpoint nodes used" list. I add them manually to a "checkpoints" collection, and then use gradients_collection(). Then, I get OOM.

I don't understand why that is so - if I take the same tensors, shouldn't the behaviour be the same?

@yaroslavvb
Copy link
Collaborator

Yes, behavior should be the same. If you notice the code after printing "Checkpoint nodes used" doesn't know whether checkpoints variable was specified manually, or automatically. So I would double-check that Checkpoint nodes used message prints the same message in both cases and debug from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants