Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write development docs #73

Open
snakescott opened this issue Jul 11, 2019 · 1 comment
Open

Write development docs #73

snakescott opened this issue Jul 11, 2019 · 1 comment

Comments

@snakescott
Copy link

I would like to poke around to see if I can improve some ncluster testing but there are no docs on development (how to run existing tests, how CI works, etc).

@yaroslavvb
Copy link
Collaborator

yaroslavvb commented Jul 11, 2019

That's because there are no tests and no CI :)

The most important test I think is ensuring that "new user" experience isn't broken -- making sure a first time user with fresh AWS account and no infrastructure can do ncluster.make_task() and things work out of the box.

I think this will require live AWS testing -- I had to rely on some undocumented AWS features which may stop working when AWS changes their ways. For example, setting up machine requires login, but AWS doesn't provide a direct way to tell whether DLAMI login name is ec2-user@, or ubuntu@, so this has to be inferred indirectly from heuristics like image.root_device_name or AMI description.

My current idea is to setup CircleCI pipeline which will run this on a testing AWS account and log results into wandb dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants