Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show unconfirmed amount in the 'amount available' on the spend screen #104

Open
cygnet3 opened this issue Feb 5, 2025 · 2 comments
Labels

Comments

@cygnet3
Copy link
Owner

cygnet3 commented Feb 5, 2025

We don't allow spending unconfirmed amounts, so we shouldn't show it either.

We can either remove it, or perhaps allow for spending unknown amounts. However, the latter could impose some risks that we may not want.

@Sosthene00
Copy link
Collaborator

I may have missed something, but since we don't detect utxos in mempool, we only add new spendable utxos by scanning blocks, hence if we add an amount to our balance it is necessarily a confirmed output, so we shouldn't have this issue, right?

@cygnet3
Copy link
Owner Author

cygnet3 commented Feb 18, 2025

We have this issue not for incoming (unconfirmed) transactions, but rather for the change outputs of outgoing unconfirmed transactions.

If a user has a 50k utxo and sends 10k, they receive a 40k change output. Even before confirming, we show this output already in the wallet balance, but users are not able to spend it yet.

It's pretty easy to just not include the unconfirmed change outputs in the spend screen. However we could also introduce the ability to allow users to spend unconfirmed change outputs, if we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants