Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isodatetime #4110

Closed
MetRonnie opened this issue Mar 4, 2021 · 4 comments
Closed

Update isodatetime #4110

MetRonnie opened this issue Mar 4, 2021 · 4 comments
Assignees
Labels
efficiency For notable efficiency improvements non-cylc bug This is a bug, but not in Cylc

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Mar 4, 2021

Describe exactly what you would like to see in an upcoming release

Update the version of isodatetime used in cylc-flow once metomi/isodatetime#176 is done and 2.1 is released. This should give performance improvements for datetime cycling workflows (see metomi/isodatetime#162). Also, if metomi/isodatetime#80 gets fixed that vanquishes a long-standing bug that is in cylc-flow.

Optimistically tagged against 8.0rc1 as it would be good to have done before then, but not a priority. See discussion below.

Pull requests welcome!

@MetRonnie MetRonnie added efficiency For notable efficiency improvements WIP labels Mar 4, 2021
@MetRonnie MetRonnie added this to the 8.x milestone Mar 4, 2021
@MetRonnie MetRonnie self-assigned this Mar 4, 2021
@MetRonnie
Copy link
Member Author

@oliver-sanders @hjoliver I have this tagged against 8.x, but seeing as there is a breaking change (metomi/isodatetime#183), would this be be better suited to 8.0.0?

@oliver-sanders
Copy link
Member

The breaking change shouldn't be a problem (Cylc is used as a system rather than a library), good to keep 8.0.0 to the more mission-critical aspects right now.

@MetRonnie
Copy link
Member Author

Forgot to mention, we could just release isodatetime 2.1.0 now and finish metomi/isodatetime#176 later in 2.1.1. Upgrading cylc-flow to isodatetime 2.1.0 shouldn't take too long.

@MetRonnie MetRonnie added the non-cylc bug This is a bug, but not in Cylc label Jul 30, 2021
@MetRonnie MetRonnie modified the milestones: 8.x, cylc-8.0.0 Jul 30, 2021
@MetRonnie
Copy link
Member Author

MetRonnie commented Jul 30, 2021

Optimistically tagged against 8.0rc1 as it would be good to have done before then, but not a priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efficiency For notable efficiency improvements non-cylc bug This is a bug, but not in Cylc
Projects
None yet
Development

No branches or pull requests

3 participants