Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload fails on adding a new xtrigger #6260

Open
hjoliver opened this issue Jul 23, 2024 · 0 comments · Fixed by #6263
Open

reload fails on adding a new xtrigger #6260

hjoliver opened this issue Jul 23, 2024 · 0 comments · Fixed by #6263
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jul 23, 2024

[scheduling]
    initial cycle point = now
    [[graph]]
        PT1M = "foo"
[runtime]
    [[foo]]
        script = sleep 10

Run the above, change the source to this then cylc vr (reload):

[scheduling]
    initial cycle point = now
    [[xtriggers]]
        x = wall_clock(offset=P1Y)
    [[graph]]
        PT1M = "@x => foo"
[runtime]
    [[foo]]
        script = sleep 10

Result:

    Traceback (most recent call last):
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/scheduler.py", line 652, in run_scheduler
        await self._main_loop()
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/scheduler.py", line 1537, in _main_loop
        self.process_queued_task_messages()
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/scheduler.py", line 907, in process_queued_task_messages
        if self.task_events_mgr.process_message(
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_events_mgr.py", line 731, in process_message
        self.spawn_children(itask, TASK_OUTPUT_SUCCEEDED)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_events_mgr.py", line 1970, in spawn_children
        self.spawn_func(itask, output)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 1440, in spawn_on_output
        self.remove_if_complete(itask, output)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 1496, in remove_if_complete
        self.release_runahead_tasks()
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 276, in release_runahead_tasks
        self.spawn_to_rh_limit(
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 803, in spawn_to_rh_limit
        self.spawn_if_parentless(tdef, point, flow_nums)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 812, in spawn_if_parentless
        self.add_to_pool(ntask)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 228, in add_to_pool
        self.create_data_store_elements(itask)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/task_pool.py", line 239, in create_data_store_elements
        self.data_store_mgr.increment_graph_window(
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/data_store_mgr.py", line 791, in increment_graph_window
        self.generate_ghost_task(
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/data_store_mgr.py", line 1266, in generate_ghost_task
        self._process_internal_task_proxy(itask, tproxy)
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/data_store_mgr.py", line 1521, in _process_internal_task_proxy
        sig = self.schd.xtrigger_mgr.get_xtrig_ctx(
      File "/home/oliverh/cylc/cylc-flow/cylc/flow/xtrigger_mgr.py", line 599, in get_xtrig_ctx
        ctx = deepcopy(self.xtriggers.functx_map[label])
    KeyError: 'x'
CRITICAL - Workflow shutting down - 'x'
@hjoliver hjoliver added the bug Something is wrong :( label Jul 23, 2024
@hjoliver hjoliver added this to the 8.3.x milestone Jul 23, 2024
@oliver-sanders oliver-sanders linked a pull request Oct 16, 2024 that will close this issue
8 tasks
@oliver-sanders oliver-sanders modified the milestones: 8.3.x, 8.3.7 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants