Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: include hidden files when uploading ~/cylc-run artifact #6309

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie added small infrastructure GH Actions, Codecov etc. labels Aug 20, 2024
@MetRonnie MetRonnie self-assigned this Aug 20, 2024
@MetRonnie MetRonnie marked this pull request as ready for review August 21, 2024 15:02
@@ -75,6 +75,7 @@ jobs:
with:
name: cylc-run (${{ matrix.os }} py-${{ matrix.python-version }})
path: ~/cylc-run/
include-hidden-files: true
Copy link
Member Author

@MetRonnie MetRonnie Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it's ok to add this already even though the option is not yet included in actions/upload-artifact@v4. Currently it just gets ignored with a warning

@MetRonnie MetRonnie requested a review from wxtim August 21, 2024 15:07
@wxtim wxtim merged commit 2e3ba22 into cylc:8.3.x Aug 22, 2024
14 of 25 checks passed
@MetRonnie MetRonnie deleted the actions branch August 22, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure GH Actions, Codecov etc. small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants