Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: clockface alignment broken in webkit/safari #1078

Closed
oliver-sanders opened this issue Jul 27, 2022 · 3 comments · Fixed by #1108
Closed

task: clockface alignment broken in webkit/safari #1078

oliver-sanders opened this issue Jul 27, 2022 · 3 comments · Fixed by #1108
Assignees
@oliver-sanders
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jul 27, 2022 •
edited
Loading

The clockface alignment has become broken in webkit/safari when zooming in/out:

Screenshot 2022-07-27 at 09 14 37

At 100% the alignment is correct.

See also #178

Pull requests welcome!
@oliver-sanders oliver-sanders added the bug Something isn't working label Jul 27, 2022
@oliver-sanders oliver-sanders added this to the 1.4.0 milestone Jul 27, 2022
@wxtim
Copy link
Member

wxtim commented Jul 27, 2022

I've tried this on RHEL7 Firefox and can't replicate it. Also tried using ctrl + and ctrl -.

@MetRonnie
Copy link
Member

I can't reproduce on Chrome or Firefox

@oliver-sanders oliver-sanders mentioned this issue Oct 28, 2022
Merged
7 tasks
@oliver-sanders oliver-sanders self-assigned this Oct 28, 2022
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Nov 4, 2022
@oliver-sanders
task: fix progress icon in webkit/safari
19b0f56 
* The progress icon was rotated but the point around which it was
  rotated was not specified. Safari/Webkit picked the centre of the
  object, Opera/Chromium picked the top-left corner. Hardcoded this
  into the rotation to avoid issues.
* Closes cylc#1078
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Nov 7, 2022
@oliver-sanders
task: fix progress icon in webkit/safari
64ff58b 
* The progress icon was rotated but the point around which it was
  rotated was not specified. Safari/Webkit picked the centre of the
  object, Opera/Chromium picked the top-left corner. Hardcoded this
  into the rotation to avoid issues.
* Closes cylc#1078
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Nov 8, 2022
@oliver-sanders
task: fix progress icon in webkit/safari
16a45a2 
* The progress icon was rotated but the point around which it was
  rotated was not specified. Safari/Webkit picked the centre of the
  object, Opera/Chromium picked the top-left corner. Hardcoded this
  into the rotation to avoid issues.
* Closes cylc#1078
@wxtim
Copy link
Member

wxtim commented Nov 23, 2022

I have reproduced this and confirmed that #1108 fixes it too. :)

@wxtim wxtim closed this as completed in c61be9c Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliver-sanders oliver-sanders

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

graph view and central data store oliver-sanders/cylc-ui
3 participants
@oliver-sanders @wxtim @MetRonnie