Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: clear the graph when there is nothing to draw #1756

Open
oliver-sanders opened this issue Apr 16, 2024 · 2 comments
Open

graph: clear the graph when there is nothing to draw #1756

oliver-sanders opened this issue Apr 16, 2024 · 2 comments
Labels
Milestone

Comments

@oliver-sanders
Copy link
Member

If there is nothing to draw, the graph view currently preserves the last valid graph. This is a little inconsistent, other views go blank.

I think there have been some issue with differentiating between empty and error states once?

We should allow the graph to go blank and, ideally, leave a placeholder where the graph would be to explain this, however, that is a different issue - #332.

@MetRonnie
Copy link
Member

I think this is a bug Something isn't working because of this from cylc/cylc-uiserver#630

An example. Note the workflow is stopped after having completed, but the task still claims to be running.

20240924_122816

@MetRonnie MetRonnie added the bug Something isn't working label Sep 24, 2024
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Sep 24, 2024

I think this is a bug because of this from cylc/cylc-uiserver#630

I don't think that's right.

  • This issue is about clearing the graph when the task pool is empty.
  • The issue you linked was about the task state not being updated before the workflow shut down.

Note that other views (e.g. the tree view) will retain the workflows last known state after it has shut down (similar to the graph view) so if the task has been left in the wrong state, that is a different bug. Possible causes:

  • Scheduler did not send the task state transition before shutting down.
  • UIS did not forward the task state transition due to the workflow shutting down.
  • UI data store did not enact the task state transition due to the presence of the shutdown delta.
  • UI Graph view became decoupled from the UI data store (so the task state change did not happen).

@MetRonnie MetRonnie removed the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants