-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GScan sort running workflows before expandable (containing run dirs) workflows #838
Comments
I think this is just awaiting hierarchical sort to be implemented.
Yep. I think this was the plan, just not implemented yet? Although hierarchical sort gets nasty, if you have multiple runs in a hierarchy we would expect them to stay together irrespective of their state. That messes with the sort order somewhat. For example, what's the correct sort order for this?
For a flat GScan it would be:
For a hierarchical GScan I think it should be:
Or (my preference):
But not:
Suggest if one workflow is running the entire hierarchy should be considered to be running (much like how if one task in a family is running the state of the family is running). And cascade the sorting from head to toe? The approach of #736 may be useful here? Would be nice to offer a purely alphabetical sort too. |
Note that this example only works if the task |
Describe the bug
At the moment, no-run-name workflows that are running are displayed before stopped non-run-name workflows, but after stopped workflows containing numbered/named run dirs.
If sorting is to be done properly, running workflows should be at the very top of the GScan sidebar.
Also, why do workflows containing run dirs come before no-run-name workflows in the sort order anyway?
Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read
CONTRIBUTING.md
before starting any work though).The text was updated successfully, but these errors were encountered: