JUCX: use google mirror + fix build on java10+. #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 03-Feb-2020
|
yosefe
reviewed
Jan 28, 2020
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> |
There was a problem hiding this comment.
is there way to avoid duplication with <repositories> ?
There was a problem hiding this comment.
repository and pluginRepositories are different:
https://stackoverflow.com/questions/45557870/repository-vs-pluginrepository
yosefe
approved these changes
Jan 28, 2020
|
Is it possible to trigger only readthedocs build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use by default google mirror for maven.
Fix build for java10+, using compiler plugin to generate native headers.
Why ?
Should be more reliable to build in containers + fixes https://github.com/DSC-SPIDAL/twister2/issues/831