-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates without importing constructive #456
Comments
What is wrong with importing constructive ? All the functions imported through the template (and all other potentially useful functions for extension) are prefixed with About auto saving I'm not sure, it'd be a permanent side effect by default, not obvious to undo, with a name that's not super explicit about it, I find it a bit rude when functions do that. That might discourage users to play around, + the risk of overriding an existing script, or to block the process if we don't overwrite. |
It's not wrong, it's just that constructive is not needed for operating the duckplyr package. It's only useful for me as a developer. I can also add the corresponding files to No strong opinion regarding autosaving. |
I can't easily My approach is to use |
Good point about having constructive in suggests, we need a message suggesting I understand now, I thought we could use the import tags and have constructive in Suggests but indeed checks fail.
It's less plug and play unfortunately but I understand the value. |
tidyverse/duckplyr#197
I should have split this into multiple commits, but haven't.
Can we also save the template into a sensible file name by default?
The text was updated successfully, but these errors were encountered: