Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center of color wheel turns out gray. #10

Open
royben opened this issue Aug 29, 2017 · 5 comments
Open

Center of color wheel turns out gray. #10

royben opened this issue Aug 29, 2017 · 5 comments
Labels

Comments

@royben
Copy link

royben commented Aug 29, 2017

image

@cyotek cyotek added the bug label Aug 29, 2017
@cyotek
Copy link
Owner

cyotek commented Aug 29, 2017

Hello,

Thanks for the bug report. If I remember correctly, this is probably the same root cause as #5 (basically due to how internally the color is converted to RGB and back). I have a bug long list of things to do, I'll try and get to sorting out the mess I made of this library sooner rather than later.

Thank you again for the report!

Regards;
Richard Moss

@allendotson
Copy link

Hi Richard!
Do you know if there is any timeline on this? Or where I would look into helping repair this?

@cyotek
Copy link
Owner

cyotek commented Apr 18, 2018

Hello,

Firstly apologies for the delay in actually replying to the issue (let alone the delaying in fixing it).

I just took a quick look to refresh my memory on how the code works and found my initial comment above seems incorrect. There are (probably, bear in mind I've spend maybe 10 minutes looking 😊) two issues, both in SetColor.

The first is the lines which reset the saturation to 0 if the distance is less than 6 - this causes the snapping to the center when you get close.

if (distance < 6)
{
  saturation = 0; // snap to center
}

Deleting those 3 lines seems a good first start.

The second issues is when the HslColor is constructed - it ignores the current lightness value and always substitutes this with 0.5. This should use the current value if that property has been set externally.

I'm actually hoping to get back onto working on our color editor Soon(tm), at which point I'll be addressing some of the high DPI issues that have been reported so I'll make a concerted effort to address this issue too.

Once again, apologies for the delay in responding or fixing.

Regards;
Richard Moss

@pc8181
Copy link

pc8181 commented Nov 18, 2018

is that fixed 2018 i just download and test the same i got gray color not white in color wheel.

@cyotek
Copy link
Owner

cyotek commented Nov 19, 2018

Hello,

No it's not fixed. I have a huge amount of work to do to the Color Picker controls and I simply haven't got time to make a start on it yet.

Regards;
Richard Moss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants