-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jonocodes/cypht container comments (latest/v2.0.1-wip) #1049
Comments
Thank you @truthsword. This is very helpful. I suspect all these issues come from 2 or 3 root causes. @jonocodes is away from the keyboard for a few days and I am at Open Source events for the upcoming 2 weeks: https://tiki.org/TikiFestParis2024 so things will slow down a bit. But @josaphatim will release Cypht 2.1.0 soon: #1050 And we will all make sure that https://hub.docker.com/u/cypht is as good as a manual install. We'll encourage the active developers to use it as much as possible. |
Great info @truthsword . Thanks for testing. Can you confirm that all these points are working with the old sailfrog image? And more importantly, if you have the resources, could you test to see if these are issues in master without docker? @marclaporte what are the 2 or 3 causes guess? |
Some were, some weren't, some were “broken” in different ways. Going by memory… What worked in sailfrog, was
What did not work in sailfrog,
I don't have a test machine to do that. Docker is simpler for me. |
@truthsword compared legacy Docker recipe with 5 month old code from master vs new Docker recipe and latest code. Hypothesis: bugs emanate from either: 1- A side effect of #625 which is a massive revamp/cleanup 3 months ago in master. I expect breakage but things will be much easier to fix now because this new design is more robust. 2- Something needs an adjustment in the new Docker recipe. Ex.: something is hard-coded to off.
I saw this and it was fixed. @truthsword was seeing because sailfrog Docker image has old code.
I don't remember seeing this nor it being fixed, so I suspect it's just a regular bug. A good one for @Shadow243 to assign to one of the new devs as a training exercise :-) |
@truthsword I expect some of the issues will be solved in Cypht 2.1.0 which should be available via Docker soon: |
@truthsword Please test with 2.1.0 https://hub.docker.com/r/cypht/cypht I predict everything will be OK except #1046 |
@truthsword Please test with https://github.com/cypht-org/cypht/releases/tag/v2.2.0 |
Thank you @truthsword for #1046 so we can keep track on it independently. |
It is on our wishlist: #1175 |
I was asked to try this image (originally I used sailfrog's image). In some ways this regressed for me. Rather than open multiple question posts, I have captured my initial impressions here.
I have used both
jonocodes/cypht:latest
andjonocodes/cypht:2.0.1-docker-wip
image tags. Thelatest
image gave me white screens when clicking the “Site” setting icon. The2.0.1-docker-wip
image displayed properly in the browser.Findings:
The text was updated successfully, but these errors were encountered: