added additional integration tests around ended early errors

cypress-io · Apr 22, 2015 · 459c61a · 459c61a
1 parent a635124
commit 459c61a
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 5 deletions.
diff --git a/spec/client/api/integration/ended_early_spec.coffee b/spec/client/api/integration/ended_early_spec.coffee
@@ -0,0 +1,13 @@
+describe "Timeout Integration Tests", ->
+  ## dont console.error errors else it makes it look
+  ## like our tests are failing!
+  enterIntegrationTestingMode("html/ended_early", {silent: true})
+
+  context "ended early", ->
+    it "correct associates runnable which ended early", (done) ->
+      runner = @Cypress.runner
+
+      @Cypress.run (failures) ->
+        test = runner.getTestByTitle("does end early [003]")
+        expect(test.err.message).to.eq "Cypress detected your test ended early before all of the commands have run. This can happen if you explicitly done() a test before all of the commands have finished."
+        done()
diff --git a/spec/client/spec_helper.coffee b/spec/client/spec_helper.coffee
@@ -42,16 +42,20 @@ window.getNames = (queue) ->
 window.getFirstSubjectByName = (name) ->
   _(@cy.queue).findWhere({name: name}).subject
 
-window.enterIntegrationTestingMode = (fixture) ->
+window.enterIntegrationTestingMode = (fixture, options = {}) ->
+  _.defaults options,
+    silent: false
+
   before ->
     @loadDom = _.bind(loadDom, @)
 
   beforeEach ->
     ## load all of the modules
     @Cypress = $Cypress.create({loadModules: true})
 
-    @Cypress.on "fail", (err) ->
-      console.error(err.stack)
+    if options.silent is false
+      @Cypress.on "fail", (err) ->
+        console.error(err.stack)
 
     @loadDom(fixture).then =>
       @Cypress.initialize @iframe.prop("contentWindow"), @iframe, ->

diff --git a/spec/fixtures/html/ended_early.html b/spec/fixtures/html/ended_early.html
@@ -0,0 +1,28 @@
+<!doctype html>
+<html>
+  <head>
+    <meta http-equiv="content-type" content="text/html;charset=utf-8" />
+    <title>Ended Early Tests</title>
+    <link rel="icon" href="data:;base64,=">
+    <script type="text/javascript" src="/lib/public/js/iframe.js"></script>
+    <script type="text/javascript">
+      describe("ending early [001]", function(){
+        beforeEach(function(){
+          cy.visit("fixtures/html/generic.html")
+        })
+
+        it("does not end early [002]", function(){
+
+        })
+
+        it("does end early [003]", function(done){
+          cy.then(function(){})
+
+          done()
+        })
+      })
+    </script>
+  </head>
+  <body>
+  </body>
+</html>
diff --git a/spec/fixtures/html/generic.html b/spec/fixtures/html/generic.html
@@ -3,5 +3,7 @@
   <head>
     <title>Generic HTML Fixture</title>
   </head>
-  <body></body>
+  <body>
+    Some generic content
+  </body>
 </html>
diff --git a/spec/fixtures/html/timeout.html b/spec/fixtures/html/timeout.html
@@ -2,7 +2,7 @@
 <html>
   <head>
     <meta http-equiv="content-type" content="text/html;charset=utf-8" />
-    <title>.Only Tests</title>
+    <title>Timeout Tests</title>
     <link rel="icon" href="data:;base64,=">
     <script type="text/javascript" src="/lib/public/js/iframe.js"></script>
     <script type="text/javascript">