internal: (studio) remove CYPRESS_ENABLE_CLOUD_STUDIO_AI env (#32625)

Author: mschile

guides/studio-development.md

@@ -11,7 +11,6 @@ To run against locally developed Studio:
 - Set environment variables:
   - `CYPRESS_INTERNAL_ENV=<environment>` (typically `staging` or `production` to hit those deployments of `cypress-services`, or `development` if you want to hit a locally running version of `cypress-services`)
   - Set `CYPRESS_LOCAL_STUDIO_PATH` to a relative path pointing to the `cypress-services/app/packages/studio/dist/development` directory (regardless of the `CYPRESS_INTERNAL_ENV` set).
-  - `CYPRESS_ENABLE_CLOUD_STUDIO_AI` to `true` if AI functionality is needed (note, the feature flag will also need to be set in the appropriate environment).
 - Clone the `cypress` repo
   - Run `yarn`
   - Run `yarn cypress:open`

packages/server/lib/cloud/studio/studio.ts

@@ -72,9 +72,7 @@ export class StudioManager implements StudioManagerShape {
   }
 
   async canAccessStudioAI (browser: Cypress.Browser): Promise<boolean> {
-    const envEnabled = process.env.CYPRESS_ENABLE_CLOUD_STUDIO_AI === 'true'
-
-    return envEnabled && !!(await this.invokeAsync('canAccessStudioAI', { isEssential: true }, browser))
+    return !!(await this.invokeAsync('canAccessStudioAI', { isEssential: true }, browser))
   }
 
   async initializeStudioAI (options: StudioAIInitializeOptions): Promise<void> {

packages/server/test/unit/cloud/studio/studio_spec.ts

@@ -137,29 +137,15 @@ describe('lib/cloud/studio', () => {
       process.env = originalEnv
     })
 
-    it('returns true when CYPRESS_ENABLE_CLOUD_STUDIO_AI is true and studio server can access AI', async () => {
-      process.env.CYPRESS_ENABLE_CLOUD_STUDIO_AI = 'true'
-
+    it('returns true when studio server can access AI', async () => {
       sinon.stub(studio, 'canAccessStudioAI').resolves(true)
 
       const result = await studioManager.canAccessStudioAI(browser)
 
       expect(result).to.be.true
     })
 
-    it('returns false when CYPRESS_ENABLE_CLOUD_STUDIO_AI is false and studio server can access AI', async () => {
-      process.env.CYPRESS_ENABLE_CLOUD_STUDIO_AI = 'false'
-
-      sinon.stub(studio, 'canAccessStudioAI').resolves(true)
-
-      const result = await studioManager.canAccessStudioAI(browser)
-
-      expect(result).to.be.false
-    })
-
-    it('returns false when CYPRESS_ENABLE_CLOUD_STUDIO_AI is true and studio server cannot access AI', async () => {
-      process.env.CYPRESS_ENABLE_CLOUD_STUDIO_AI = 'true'
-
+    it('returns false when studio server cannot access AI', async () => {
       sinon.stub(studio, 'canAccessStudioAI').resolves(false)
 
       const result = await studioManager.canAccessStudioAI(browser)