Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_rfc5490_mailboxexists_variables fails for 3.0 #2317

Closed
elliefm opened this issue Apr 13, 2018 · 2 comments
Closed

test_rfc5490_mailboxexists_variables fails for 3.0 #2317

elliefm opened this issue Apr 13, 2018 · 2 comments
Assignees
Labels
3.0 affects 3.0

Comments

@elliefm
Copy link
Contributor

elliefm commented Apr 13, 2018

This looks like an actual Cyrus bug. The test sends two messages and expects one to land in the hit folder, the other in the miss folder.

On 3.0, they both wind up in the same folder (not sure which, I haven't looked into this deeply yet), causing the test to fail with either "expected 1, got 0" or "expected 1, got 2" (depending on which folder it checks first, I'm not sure if the order is significant).

It's fine on master.

@ksmurchison Are you aware of anything that'd cause this in the older implementation? I don't want to backport your recent refactor, but maybe it was already fixed before that? Or maybe this was the issue that prompted the refactor? I'm not sure!

@elliefm elliefm added the 3.0 affects 3.0 label Apr 13, 2018
@elliefm
Copy link
Contributor Author

elliefm commented Apr 13, 2018

cyrusimap/cassandane#54 is the same issue on the Cassandane repository fwiw.

@elliefm
Copy link
Contributor Author

elliefm commented Apr 18, 2018

This was fixed in 3387587 on master, and Ken has cherry-picked it to 3.0 as bb1716d

@elliefm elliefm closed this as completed Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 affects 3.0
Projects
None yet
Development

No branches or pull requests

2 participants