Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing waveforms(functions) to the LiveNIDaq #126

Open
AhmetCanSolak opened this issue Sep 29, 2022 · 0 comments
Open

Introducing waveforms(functions) to the LiveNIDaq #126

AhmetCanSolak opened this issue Sep 29, 2022 · 0 comments
Labels
feature request New feature or request good first issue Good for newcomers hardware help wanted Extra attention is needed
Milestone

Comments

@AhmetCanSolak
Copy link
Contributor

FEATURE: Introducing waveforms(functions) to the LiveNIDaq

Is your feature request related to a problem? Please describe.

Currently the LiveNIDaq API offers to users a way to set certain voltage values to desired analog channel at a time. It can be found here: https://github.com/royerlab/coPylot/blob/f99a3b7ea654fb8e7d5dd2f213cde6c5ab726c38/copylot/hardware/ni_daq/live_nidaq.py#L33 . Users can implement their own functions using this API to generate certain signal waveforms and this can be exhausting and error prone. Here I like to propose providing common waveforms within coPylot so we can implement and test it in one-place for all.

Describe the solution you'd like

Final implementation I like to see consist of functions for each unique waveform that can stream the required voltages for the desired waveform with given sampling rate and characteristics. These can be member functions to existing LiveNIDaq class for now and we can consider later if they deserve a separate module. I like to see following waveforms (for now, and the list below can be extended at any time):

  • sine
  • square
  • ramp
@AhmetCanSolak AhmetCanSolak added feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 29, 2022
@AhmetCanSolak AhmetCanSolak added this to the 0.0.1 milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers hardware help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant