Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the abstract class for the mirror #167

Open
edyoshikun opened this issue Jun 6, 2023 · 5 comments
Open

Implement the abstract class for the mirror #167

edyoshikun opened this issue Jun 6, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation feature request New feature or request

Comments

@edyoshikun
Copy link
Contributor

Similar to issue #166. The mirrors require an abstract class that should include the following:

-[ ] Get/Set position (already implemented but needs to be written in the abstract class)
-[ ] Get/Set relative position
-[ ]Get/Set Movement Limits
-[ ] Get/Set step resolution
-[ ] Set Home()
-[ ] Set Origin(). Do you think this should be per axis?

Should we standardize this to a specific unit of measurement (i.e deg or um)?
Should we have a position buffer or do we just generate that with some np.linspace()?

@AhmetCanSolak @YangLiujames

@edyoshikun edyoshikun added documentation Improvements or additions to documentation feature request New feature or request labels Jun 6, 2023
@AhmetCanSolak
Copy link
Contributor

@edyoshikun what do you mean by Movement Limits and Origin exactly?

@edyoshikun
Copy link
Contributor Author

@AhmetCanSolak for the movement limits I meant the min/max range on the axis (i.e the optotune has some max degree of rotation, and the galvos also have a maximum scan angle).
For Origin, I guess that's a convenient function to move to the origin. Most devices probably to (0,0) or center?

@YangLiujames
Copy link
Contributor

@edyoshikun The maximum moment limits already built in and if you read the docstring carefully it also explains a bit which why we have a limit of 1.

@edyoshikun
Copy link
Contributor Author

@YangLiujames the abstract class as it states is for global use not just for the optotune mirror. These should be exposed at a higher level. Currently, the optotune only has the position() and none of the mentioned above.

@YangLiujames
Copy link
Contributor

YangLiujames commented Jun 7, 2023

We should either do some sort of normalization like optotune or convert it back to degree or voltage. in that case.

The optotune mirror.py docstring stated the limits... we can add an additional function say the limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants