You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ieivanov thanks for making this! I think this is a nice example to test against. One very minor point is that it would be nice to have non-single digit column numbers (e.g. 12) to prevent future regressions.
Yup, I can make that happen. I'll have to re-acquire this dataset anyway as we saw that the data is of the wrong file size due to a MM bug somewhere (micro-manager/micro-manager#1746)
One wrinkle we missed yesterday - an important feature of the iohub readers is adding singleton dimensions where they may be missing. In the test data we should include acquisitions with fewer than 5 dimensions to test that iohub correctly turns those into TCZYX datasets
In the test data we should include acquisitions with fewer than 5 dimensions to test that iohub correctly turns those into TCZYX datasets
This is already tested with the older (2020-gamma) MM datasets. I don't think we need to acquire the full suite of the combinations unless we aim to replace the old ones completely.
EDIT: Check if this fits the bill:
cm.mantis/2023_07_21_mm_hsc_dataset/mm_hsc_dataset_2
Originally posted by @ieivanov in #159 (comment)
The text was updated successfully, but these errors were encountered: