Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deskew configuration file's px_to_scan_ratio parameter is redundant with scale metadata #101

Open
talonchandler opened this issue Sep 22, 2023 · 0 comments

Comments

@talonchandler
Copy link
Contributor

When we developed deskew we were not passing scale metadata correctly, so we needed to pass px_to_scan_ratio to the routine. Now we are passing scale metadata, so px_to_scan_ratio can be omitted from the deskew configuration file.

  • I am only suggesting that we drop px_to_scan_ratio from the CLI interface...the lower level interfaces should keep this parameter
  • This requires datasets to have correct scale metadata, but we can modify old or incorrect datasets with mantis update-scale-metadata
  • This is not a severe problem, but it did cause me some confusion as I was debugging my PSF figures. I (incorrectly) thought I could copy the px_to_scan_ratio from a working deskew parameter file, but actually I needed to calculate this from the input data scales.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant