Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Database best-practises #403

Open
dmohns opened this issue Sep 17, 2024 · 0 comments
Open

Implement Database best-practises #403

dmohns opened this issue Sep 17, 2024 · 0 comments

Comments

@dmohns
Copy link
Contributor

dmohns commented Sep 17, 2024

Reason: Currently, in the Postgres DB that is used for the backend some best practices are not implemented. For example

  • Make column names intuitive. There is a column called ExternalID However, this column is the internal non-user facing id of devices. The actual “external” ID, that is set by the device operator is called developerExternalId
  • Make column names consistent. Postgres is case-sensitive. Sometimes we have externalId sometimes device_externalid
  • roleId in user table should be a FOREIGN KEY to user_role

Steps: Implement best practices from the list above.

Definition of done: Implement best practices from the list above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant