Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnessacary Vec::retain when executing sc.d/w instruction #31

Open
lenawanel opened this issue May 26, 2024 · 0 comments · May be fixed by #35
Open

unnessacary Vec::retain when executing sc.d/w instruction #31

lenawanel opened this issue May 26, 2024 · 0 comments · May be fixed by #35

Comments

@lenawanel
Copy link

rvemu/src/cpu.rs

Line 1814 in f55eb5b

self.reservation_set.retain(|&x| x != addr);

rvemu/src/cpu.rs

Line 1793 in f55eb5b

self.reservation_set.retain(|&x| x != addr);

both of these lines do nothing, as

rvemu/src/cpu.rs

Line 1786 in f55eb5b

if self.reservation_set.contains(&addr) {
already has shown that addr is not in the reservation set, when reaching these lines.

lenawanel added a commit to lenawanel/rvemu that referenced this issue May 29, 2024
@lenawanel lenawanel linked a pull request May 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant