Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

/r/Android AppStore Slide Outs #102

Closed
GiantWaffle opened this issue Jul 15, 2017 · 4 comments
Closed

/r/Android AppStore Slide Outs #102

GiantWaffle opened this issue Jul 15, 2017 · 4 comments

Comments

@GiantWaffle
Copy link

Thanks for the App Store! :-)

This is not a "bug", per se, but sort of.

When a slide out is open, by tapping or swiping anything, like the 3-bar at the top left, or the pyramid at the top right, once something slides out (vertically or horizontally) and you tap the Back Arrow, it should close the Slide Out, not the app.

As you know, apps normally do it that way, so (no offense) it's kind of annoying to use it like you'd normally use an app and have it keep closing on you.

Thanks!

@bobheadxi
Copy link
Collaborator

Thanks for the feedback! Will get this fixed as part of #65 once we get around to it :)

@GiantWaffle
Copy link
Author

Thank you! :-)

@krissrex
Copy link
Contributor

krissrex commented Aug 6, 2017

I have fixed this :) PR coming soon

krissrex added a commit to krissrex/reddit-android-appstore that referenced this issue Aug 6, 2017
Added methods to BaseActivity to listen for back key presses.
Registered a listener in MainActivity and AppListFragment to close
navigation and filter drawers when they were visible.

Add methods for listening to back press

Use BaseActivity's interface for closing DrawerLayouts
@GiantWaffle
Copy link
Author

Thank You! :-)

Btw, just to mention it in case it's an issue (I haven't looked at it much, 'cause waiting for the update), could you please make sure that in the code, for when it lists apps (or anything) out, that it is set to "Ignore Case"?

Otherwise, apps that start with "aa" can end up being listed after "Zz", depending on Case.

"Ignore Case" is not Enabled by default in Android and so it ends up listing not alphabetically, as follows (please note caps and no caps):

ZZ
Aa
Za
aa

Yup! That's actually how Android will list them out, if not all Names/Titles follow the "first letter upper case, second letter lower case" format.

Thanks Again! :-)

Dave

@d4rken d4rken closed this as completed in ef67004 Aug 10, 2017
@bobheadxi bobheadxi added this to the v0.8.0 milestone Aug 18, 2017
bobheadxi pushed a commit that referenced this issue Sep 6, 2017
Added methods to BaseActivity to listen for back key presses.
Registered a listener in MainActivity and AppListFragment to close
navigation and filter drawers when they were visible.

Add methods for listening to back press

Use BaseActivity's interface for closing DrawerLayouts
bobheadxi added a commit that referenced this issue Sep 6, 2017
bobheadxi added a commit that referenced this issue Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants