From 22491185b7c745a2f0edf25a6c8e1a3c6f6a35d2 Mon Sep 17 00:00:00 2001
From: Stefan Hagspiel <shagspiel@dachcom.ch>
Date: Sun, 11 Feb 2024 20:01:22 +0100
Subject: [PATCH] adjust tests (#436)

---
 .github/workflows/codeception.yml                   | 4 +---
 tests/Functional/Constraints/BicConstraintCest.php  | 2 +-
 tests/Functional/Constraints/IbanConstraintCest.php | 2 +-
 tests/Functional/Constraints/IpConstraintCest.php   | 2 +-
 tests/_envs/github.yml                              | 5 ++---
 5 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/codeception.yml b/.github/workflows/codeception.yml
index 759e1e50..5b594502 100644
--- a/.github/workflows/codeception.yml
+++ b/.github/workflows/codeception.yml
@@ -98,9 +98,7 @@ jobs:
 
             -   name: Setup Chromium
                 run: |
-                    export DISPLAY=:99
-                    chromedriver --url-base=/wd/hub &
-                    sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 &
+                    nohup $CHROMEWEBDRIVER/chromedriver --url-base=/wd/hub /dev/null 2>&1 &
 
             -   name: Start Symfony Server
                 run: |
diff --git a/tests/Functional/Constraints/BicConstraintCest.php b/tests/Functional/Constraints/BicConstraintCest.php
index 070de06c..ffc12cbb 100644
--- a/tests/Functional/Constraints/BicConstraintCest.php
+++ b/tests/Functional/Constraints/BicConstraintCest.php
@@ -14,7 +14,7 @@ class BicConstraintCest extends AbstractConstraintCest
     /**
      * @var string
      */
-    protected $defaultErrorMessage = 'This is not a valid Business Identifier Code (BIC)';
+    protected $defaultErrorMessage = 'This value is not a valid Business Identifier Code (BIC)';
 
     /**
      * @var string
diff --git a/tests/Functional/Constraints/IbanConstraintCest.php b/tests/Functional/Constraints/IbanConstraintCest.php
index 6f0050db..5103d808 100644
--- a/tests/Functional/Constraints/IbanConstraintCest.php
+++ b/tests/Functional/Constraints/IbanConstraintCest.php
@@ -14,7 +14,7 @@ class IbanConstraintCest extends AbstractConstraintCest
     /**
      * @var string
      */
-    protected $defaultErrorMessage = 'This is not a valid International Bank Account Number (IBAN)';
+    protected $defaultErrorMessage = 'This value is not a valid International Bank Account Number (IBAN)';
 
     /**
      * @var string
diff --git a/tests/Functional/Constraints/IpConstraintCest.php b/tests/Functional/Constraints/IpConstraintCest.php
index 87e881cf..a82fbc04 100644
--- a/tests/Functional/Constraints/IpConstraintCest.php
+++ b/tests/Functional/Constraints/IpConstraintCest.php
@@ -14,7 +14,7 @@ class IpConstraintCest extends AbstractConstraintCest
     /**
      * @var string
      */
-    protected $defaultErrorMessage = 'This is not a valid IP address';
+    protected $defaultErrorMessage = 'This value is not a valid IP address';
 
     /**
      * @var string
diff --git a/tests/_envs/github.yml b/tests/_envs/github.yml
index d8a15864..0cd67170 100644
--- a/tests/_envs/github.yml
+++ b/tests/_envs/github.yml
@@ -5,9 +5,8 @@ modules:
             port: 9515
             restart: true
             wait: 1
-            window_size: 1280x1024
             capabilities:
-                chromeOptions:
-                    args: ['--no-sandbox', '--disable-extensions', '--headless', '--disable-gpu', '--disable-dev-shm-usage']
+                'goog:chromeOptions':
+                    args: ['--no-sandbox', '--disable-extensions', '--headless', '--disable-gpu', '--disable-dev-shm-usage', '--window-size=1280,1024']
                     prefs:
                         download.default_directory: '%TEST_BUNDLE_TEST_DIR%/_data/downloads'
\ No newline at end of file