Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AutoMapper FEC branch to pass all the tests #222

Open
dadhi opened this issue Aug 31, 2019 · 8 comments
Open

Make AutoMapper FEC branch to pass all the tests #222

dadhi opened this issue Aug 31, 2019 · 8 comments
Labels

Comments

@dadhi
Copy link
Owner

dadhi commented Aug 31, 2019

The branch: https://github.com/AutoMapper/AutoMapper/tree/FastExpressionCompiler

@dadhi
Copy link
Owner Author

dadhi commented Sep 30, 2019

Baseline:

image

@jogibear9988
Copy link
Contributor

image

@jogibear9988
Copy link
Contributor

jogibear9988 commented Dec 17, 2019

The exception happens outside of running custom IL.
Already generating crashes...

Also "dynamic" is used in some tests, don't think it is supported already?

@dadhi
Copy link
Owner Author

dadhi commented Dec 17, 2019

Hi, what is the version did you check?

Dynamic is not supported (or rather is not tested)

@jogibear9988
Copy link
Contributor

its the latest

@dadhi
Copy link
Owner Author

dadhi commented Dec 17, 2019

Ok. Thanks for checking.

I have started work to fix AM some time ago - here is the updated branch in my fork https://github.com/dadhi/AutoMapper/tree/FECv3

The main problem is that AM expressions are big and complex, and composed in a multiple places - so I wanted to expect them with lately added LightExpression.ToCodeString. So I've started to switch AM from the System Expression to FEC.LightExpression and immediately stuck on the missing ExpressionVisitor support. So I've copied System ExpressionVisitor and started the conversion - it is currently in progress - I've pushed it as-is (does not compile yet) into the branch.

I am not sure when I can return back to this code because I have other things to finish.

@dadhi dadhi added the application The real-world use-case label Mar 25, 2021
@dadhi
Copy link
Owner Author

dadhi commented May 4, 2021

v3.1 update:

image

dadhi added a commit that referenced this issue May 4, 2021
@dadhi
Copy link
Owner Author

dadhi commented Oct 24, 2024

Done, but we should add some kind of regression testing for the new versions on FEC and AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants