Make {: one token instead of two for annotations
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to get rid of many `IF(IsAttribute())` manual
disambiguations.
Note that IsExistentialGuard needed to be updated to look for
lbracecolon instead of lbrace followed by colon.
Also note that strictly speaking, this is a breaking change:
Previously, `{ :myAttribute}` was accepted, but now it isn't any
more, and you have to remove the space.
But the whole test suite passes, so I think it's ok to enforce
a consistent style of not allowing a space between `{` and `:`.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on Exceptions, I was surprised that in annotations,
{:is two tokens.At some point, this created a problem because in order to distinguish between set display
{1, 2, 3}and{:myAnnotation}, a lookahead was needed. However, I changed the parser again, so it's not a problem any more and I believe I could implement Exceptions without making{:one token.But still, I think making
{:one token would simplify things, so I'm making this PR.Note that strictly speaking, this is a breaking change: Previously,
{ :myAttribute}was accepted, but now it isn't any more, and you have to remove the space. But the whole test suite passes, so I think it's ok to enforce a consistent style of not allowing a space between{and:.