Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The unresolved quotes check for search evaluates true for quotes inside the string #271

Closed
aaronhelton opened this issue Mar 1, 2024 · 2 comments
Closed

The unresolved quotes check for search evaluates true for quotes inside the string #271

aaronhelton opened this issue Mar 1, 2024 · 2 comments
Assignees
@jbukhari
Milestone
v1.4.4

Comments

@aaronhelton
Copy link
Member

aaronhelton commented Mar 1, 2024 •
edited
Loading

dlx/dlx/marc/query.py

Line 44 in b4f554c

elif char == '"':

e.g., if you are trying to save an auth heading 110 $aFoo "bar/baz" bay the checking for quotes during tokenization ends up saying the quote is unresolved. This ultimately prevents such headings from being saved.

@jbukhari
@aaronhelton
Copy link
Member Author

dag-hammarskjold-library/dlx-rest#1357

@jbukhari jbukhari self-assigned this May 9, 2024
@jbukhari jbukhari added this to the v1.4.4 milestone May 29, 2024
@jbukhari
Copy link
Member

jbukhari commented Jun 4, 2024

@aaronhelton I think this is/was an issue at the DLX-REST level

@jbukhari jbukhari closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbukhari jbukhari

Labels
None yet
Projects
None yet
Milestone
v1.4.4
Development

No branches or pull requests
2 participants
@aaronhelton @jbukhari