Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmarks #12

Open
dagit opened this issue Jul 22, 2021 · 4 comments
Open

add benchmarks #12

dagit opened this issue Jul 22, 2021 · 4 comments

Comments

@dagit
Copy link
Owner

dagit commented Jul 22, 2021

I went crazy with adding INLINE and that's gotta have some drawbacks somewhere. Maybe we can figure that out with better benchmarks. Plus I need to publish the benchmarks I'm currently using privately.

@dagit dagit self-assigned this Jul 22, 2021
@dagit
Copy link
Owner Author

dagit commented Jul 22, 2021

We now have benchmarks! I still need to add my path generator benchmark.

@dagit
Copy link
Owner Author

dagit commented Jul 24, 2021

@viercc I just added GHC 9.0.1 to the CI build and I noticed that the benchmarks don't build on GHC 9. Do you know anything about that? It's weird because it's a type error and I find that very odd. For now I just disabled the benchmarks on ghc 9, but I'd like to get them working there.

@viercc
Copy link
Contributor

viercc commented Jul 24, 2021

@dagit I guess it's something to do with the change in how type checking works with RankNTypes.

I checked (locally) the fix is to change the 160th line in logic-performance.hs like below

@@ -157,7 +157,7 @@
-forEachMonad :: (forall m. Int -> (MonadLogic m) => m ()) -> [Benchmark]
+forEachMonad :: (forall m. (MonadLogic m) => Int -> m ()) -> [Benchmark]

@dagit
Copy link
Owner Author

dagit commented Jul 24, 2021

Thanks! Yeah that fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants