Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pynotify to use SQLAlchemy rather than psycopg2 directly #2091

Open
mgasner opened this issue Jan 28, 2020 · 1 comment
Open

Rewrite pynotify to use SQLAlchemy rather than psycopg2 directly #2091

mgasner opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
area: integrations Related to general integrations, including requests for a new integration tech-debt Problems with current implementation of a system/feature

Comments

@mgasner
Copy link
Contributor

mgasner commented Jan 28, 2020

psycopg2 uses raw libpq connection strings, but sqlalchemy has its own format -- postgresql+psycopg2://... is valid for the latter but not the former

@mgasner mgasner added the area: integrations Related to general integrations, including requests for a new integration label Jan 28, 2020
@mgasner mgasner self-assigned this Jan 28, 2020
@natekupp
Copy link
Contributor

This is also attractive because pynotify has very low test coverage in our codebase

@natekupp natekupp added this to the 0.9.0 (planned) milestone Jun 1, 2020
@natekupp natekupp modified the milestones: 0.9.0, 0.9.x Sep 16, 2020
@natekupp natekupp modified the milestones: 0.9.x, 0.10.0 Nov 10, 2020
@alangenfeld alangenfeld added the tech-debt Problems with current implementation of a system/feature label Mar 30, 2021
@sryza sryza removed this from the 0.10.0 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integrations Related to general integrations, including requests for a new integration tech-debt Problems with current implementation of a system/feature
Projects
None yet
Development

No branches or pull requests

4 participants