Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the origin of required resources when initializing #2307

Open
natekupp opened this issue Mar 22, 2020 · 1 comment
Open

Log the origin of required resources when initializing #2307

natekupp opened this issue Mar 22, 2020 · 1 comment
Labels
area: logging Related to Logging area: resource Related to Resources type: good first issue Good for newcomers

Comments

@natekupp
Copy link
Contributor

Saw this in the logs as I'm trying to update "spark" to "pyspark":

dagster_examples_tests/airline_demo_tests/test_types.py 2020-03-22 13:01:48 - dagster - DEBUG - spark_df_test_pipeline - eafd4196-4fad-42bc-bbcf-d264f7d923b0 - ENGINE_EVENT - Starting initialization of resources [pyspark, spark].

It's super helpful to see what resources are being initialized (this was my clue I had missed something) - but would be even better to log where the resources are being required from. In this case I was bit by #1983

@natekupp
Copy link
Contributor Author

Would be nice to have a summary like:

Starting initialization of resources:
pyspark - required by solid instances [foo, bar]
spark - required by ...
...

@mgasner mgasner added area: logging Related to Logging core labels Mar 29, 2020
@natekupp natekupp added this to the 0.9.0 (planned) milestone Jun 1, 2020
@natekupp natekupp modified the milestones: 0.9.0, 0.9.x Sep 16, 2020
@natekupp natekupp modified the milestones: 0.9.x, 0.10.0 Nov 10, 2020
@catherinewu catherinewu added the type: good first issue Good for newcomers label Mar 3, 2021
@sryza sryza removed this from the 0.10.0 milestone Apr 1, 2021
@yuhan yuhan added the area: resource Related to Resources label May 14, 2021
@yuhan yuhan removed the core label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: logging Related to Logging area: resource Related to Resources type: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants