Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsist type annotation in build_schedule_from_dbt_selection #27366

Open
tmastny opened this issue Jan 24, 2025 · 0 comments
Open

Inconsist type annotation in build_schedule_from_dbt_selection #27366

tmastny opened this issue Jan 24, 2025 · 0 comments
Labels
type: bug Something isn't working

Comments

@tmastny
Copy link

tmastny commented Jan 24, 2025

What's the issue?

The tags parameter is annotated as tags: Optional[Mapping[str, str]] = None,

def build_schedule_from_dbt_selection(
dbt_assets: Sequence[AssetsDefinition],
job_name: str,
cron_schedule: str,
dbt_select: str = "fqn:*",
dbt_exclude: Optional[str] = None,
schedule_name: Optional[str] = None,
tags: Optional[Mapping[str, str]] = None,
config: Optional[RunConfig] = None,
execution_timezone: Optional[str] = None,
default_status: DefaultScheduleStatus = DefaultScheduleStatus.STOPPED,

This parameter is immediately forwarded to define_asset_job:

job=define_asset_job(
name=job_name,
selection=build_dbt_asset_selection(
dbt_assets,
dbt_select=dbt_select,
dbt_exclude=dbt_exclude,
),
config=config,
tags=tags,

However, the tags parameter there is annotated as tags: Optional[Mapping[str, object]] = None,

def define_asset_job(
name: str,
selection: Optional["CoercibleToAssetSelection"] = None,
config: Optional[
Union[ConfigMapping, Mapping[str, Any], "PartitionedConfig", "RunConfig"]
] = None,
description: Optional[str] = None,
tags: Optional[Mapping[str, object]] = None,
run_tags: Optional[Mapping[str, object]] = None,

What did you expect to happen?

I expected the type annotation to match.

How to reproduce?

No response

Dagster version

Copy/pasted from master.

Deployment type

None

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@tmastny tmastny added the type: bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant