Retry ECS START_TIMEOUT from run monitoring #26183
Open
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: About 1% of ECS tasks fail to start. This change allows those unresponsive tasks to be retried from the run monitoring. What changed: - Implement resume_run() for ECS Run Launcher (by simply copying the launch_run() logic) - Modify monitor_starting_run() to consider retries - Pass BaseWorkspaceRequestContext from execute_run_monitoring_iteration() to monitor_starting_run()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
About 1% of ECS tasks fail to start. This change allows those unresponsive tasks to be retried from the run monitoring.
How I Tested These Changes
N/A
Changelog
resume_run()for ECS Run Launcher (by simply copying thelaunch_run()logic)monitor_starting_run()to consider retriesBaseWorkspaceRequestContextfromexecute_run_monitoring_iteration()tomonitor_starting_run()